Allow table rotation and resizing to be disabled #36
Conversation
This allows tables to be integrated with an external pager
| it 'ignores the maximum width constraint' do | ||
| expect(columns).not_to receive(:shrink) | ||
| column_widths = columns.enforce | ||
| expect(column_widths).to eql([2,2,2,2]) |
There was a problem hiding this comment.
Layout/SpaceAfterComma: Space missing after comma.
| context 'without resize (nil)' do | ||
| let(:options) { { width: 8, resize: nil }} | ||
|
|
||
| it 'ignores the maximum width constraint' do |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -54,6 +54,17 @@ | |||
| expect(table.orientation.name).to eql(:vertical) | |||
| end | |||
| end | |||
|
|
|||
| context 'without resize (nil)' do | |||
| let(:options) { { width: 8, resize: nil }} | |||
There was a problem hiding this comment.
Layout/SpaceInsideBlockBraces: Space missing inside }.
| @@ -54,6 +54,17 @@ | |||
| expect(table.orientation.name).to eql(:vertical) | |||
| end | |||
| end | |||
|
|
|||
| context 'without resize (nil)' do | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -42,7 +42,7 @@ | |||
| end | |||
| end | |||
|
|
|||
| context 'without resize' do | |||
| context 'without resize (false)' do | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Hi William, Thanks for using Agreed, there should be a way to disable automatic rotation. I'm not sure though this is the approach I'd take to tackle this. The |
|
Okay I will look into making the change from Just one reservation about the naming of the new How about a |
|
I share your naming concern. Having said that, I usually stay away from naming options |
| context 'without resize nor rotate' do | ||
| let(:options) { { width: 8, resize: false, rotate: false } } | ||
|
|
||
| it 'does not alter the column width nor table orientation' do |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -54,6 +54,17 @@ | |||
| expect(table.orientation.name).to eql(:vertical) | |||
| end | |||
| end | |||
|
|
|||
| context 'without resize nor rotate' do | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -42,8 +42,8 @@ | |||
| end | |||
| end | |||
|
|
|||
| context 'without resize' do | |||
| let(:options) { { width: 8, resize: false }} | |||
| context 'with rotate and without resize' do | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Okay I've added the |
I've been having a couple of issues with the
resizefeature and external pagers. When rendering an extra large table withless, one of the two happens:resize: falsethe table is rotated, orresize: truethe table is shrunk.This occurs because the terminal width is not "technically increased" by the pager. However in practice the width is infinitely large. Instead it would be useful if the resizing and rotation feature can be disabled entirely.
I have updated
ColumnConstraintto support aresize: niloption which disables the terminal width check. This causes the table to be rendered according to its nature_width. Then a pager can handle the extra wide tables.Both the
resize: trueandresize: falseoptions are unaffected by this change add the default is stillfalse.