fix: reference should include computed property inside MemberExpression

closes #135
pionxzh · Aug 10, 2024 · 7d3a3c2 · 7d3a3c2
1 parent 3d59d53
commit 7d3a3c2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/ast-utils/src/reference.ts b/packages/ast-utils/src/reference.ts
@@ -177,7 +177,7 @@ export function findReferences(
         .filter(path => isVariableIdentifier(j, path))
         .filter((path) => {
             // ignore properties (e.g. in MemberExpression
-            if (path.name === 'property') return false
+            if (path.name === 'property' && j.MemberExpression.check(path.parent.node) && !path.parent.node.computed) return false
 
             if (!path.scope) return false
 

diff --git a/packages/unminify/src/transformations/__tests__/smart-rename.spec.ts b/packages/unminify/src/transformations/__tests__/smart-rename.spec.ts
@@ -39,7 +39,7 @@ const foo2 = ({
   dispatchers: o,
   listener: i
 }) => {
-  o.delete(t, i);
+  t[o].delete(i);
 }
 
 const foo3 = function ({
@@ -92,7 +92,7 @@ const foo2 = ({
   dispatchers,
   listener
 }) => {
-  dispatchers.delete(gql, listener);
+  gql[dispatchers].delete(listener);
 }
 
 const foo3 = function ({