Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused waiting field #306

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Remove unused waiting field #306

merged 1 commit into from
Jul 23, 2024

Conversation

cnderrauber
Copy link
Member

Remove unused waiting field

Remove unused waiting field
Copy link
Member

@edaniels edaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops my bad; that was sloppy. LGTM

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (a0000b2) to head (6069ab0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   83.02%   83.01%   -0.01%     
==========================================
  Files          39       39              
  Lines        2721     2720       -1     
==========================================
- Hits         2259     2258       -1     
+ Misses        336      335       -1     
- Partials      126      127       +1     
Flag Coverage Δ
go 82.84% <ø> (-0.01%) ⬇️
wasm 65.05% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cnderrauber cnderrauber merged commit 8754ef1 into master Jul 23, 2024
15 checks passed
@cnderrauber cnderrauber deleted the remove_unused branch July 23, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants