Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse timer in Deadline #290

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Reuse timer in Deadline #290

merged 1 commit into from
Apr 28, 2024

Conversation

paulwe
Copy link
Contributor

@paulwe paulwe commented Apr 27, 2024

before

BenchmarkDeadline/Set-10         	 1535445	       784.3 ns/op	     456 B/op	       6 allocs/op

after

BenchmarkDeadline/Set-10         	13248633	        79.64 ns/op	       0 B/op	       0 allocs/op

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 83.36%. Comparing base (d9ad54c) to head (e9bc06e).

Files Patch % Lines
deadline/deadline.go 90.00% 2 Missing and 1 partial ⚠️
deadline/timer_js.go 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   83.24%   83.36%   +0.11%     
==========================================
  Files          38       40       +2     
  Lines        2734     2759      +25     
==========================================
+ Hits         2276     2300      +24     
- Misses        333      334       +1     
  Partials      125      125              
Flag Coverage Δ
go 83.08% <90.62%> (+0.04%) ⬆️
wasm 65.44% <86.66%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulwe paulwe force-pushed the reuse-deadline-timer branch 2 times, most recently from 853a2e6 to e8ed9cd Compare April 27, 2024 14:05
Copy link

@boks1971 boks1971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! But, would be good to get another pair of 👀 on this.

Amazing improvement in the benchmark!

@paulwe paulwe force-pushed the reuse-deadline-timer branch 9 times, most recently from c6e8ba6 to 9f2a67b Compare April 27, 2024 21:58
@paulwe paulwe merged commit f99e891 into master Apr 28, 2024
15 checks passed
@paulwe paulwe deleted the reuse-deadline-timer branch April 28, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants