Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android 11 suppored #272

Merged
merged 1 commit into from
Jul 22, 2024
Merged

android 11 suppored #272

merged 1 commit into from
Jul 22, 2024

Conversation

suutaku
Copy link
Contributor

@suutaku suutaku commented Jan 1, 2024

Description

using a wrapper of net package to support android 11

Reference issue

Fixes

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (7cf567b) to head (32e0017).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   83.00%   83.07%   +0.07%     
==========================================
  Files          39       39              
  Lines        2730     2730              
==========================================
+ Hits         2266     2268       +2     
+ Misses        338      336       -2     
  Partials      126      126              
Flag Coverage Δ
go 82.90% <100.00%> (ø)
wasm 65.11% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der
Copy link
Member

Sean-Der commented Jan 1, 2024

Looks good to me @suutaku!

Mind fixing CI errors?

G601: Implicit memory aliasing in for loop. (gosec)
The preceding commit message is invalid
it failed 'Capitalize the subject line' of the following checks

* Separate subject from body with a blank line
* Limit the subject line to 50 characters
* Capitalize the subject line
* Do not end the subject line with a period
* Wrap the body at 72 characters

@suutaku
Copy link
Contributor Author

suutaku commented Jan 2, 2024

Looks good to me @suutaku!

Mind fixing CI errors?

G601: Implicit memory aliasing in for loop. (gosec)
The preceding commit message is invalid
it failed 'Capitalize the subject line' of the following checks

* Separate subject from body with a blank line
* Limit the subject line to 50 characters
* Capitalize the subject line
* Do not end the subject line with a period
* Wrap the body at 72 characters

Thanks! i will update it.

Fix netlink permission issue by using anet wrapper
to get net interface and addresses.
@edaniels edaniels merged commit 3ba6182 into pion:master Jul 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants