Skip to content

fix: add missing -DBOARD_HAS_PSRAM to qio_opi boards#478

Merged
Jason2866 merged 5 commits into
developfrom
fix/board-psram-flags
Apr 15, 2026
Merged

fix: add missing -DBOARD_HAS_PSRAM to qio_opi boards#478
Jason2866 merged 5 commits into
developfrom
fix/board-psram-flags

Conversation

@coderabbitai
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot commented Apr 15, 2026

Summary

Five board JSON manifests with memory_type=qio_opi were missing the -DBOARD_HAS_PSRAM flag in build.extra_flags, even though they all have OPI PSRAM. This caused the PSRAM detection in builder/frameworks/espidf.py to rely on the memory_type string as a fallback rather than the explicit flag.

Affected Boards

File Board Name
boards/atd147_s3.json ArtronShop ATD1.47-S3
boards/dfrobot_romeo_esp32s3.json DFRobot Romeo ESP32-S3
boards/lilygo-t-display-s3.json LilyGo T-Display-S3
boards/m5stack-atoms3u.json M5Stack AtomS3U
boards/nebulas3.json Kinetic Dynamics Nebula S3

Change

Added -DBOARD_HAS_PSRAM to build.extra_flags for each affected board.

Related

Identified during review of PR #477 (Refactor: Hybrid Compile sdkconfig handling).

Requested by @Jason2866.

@coderabbitai
Copy link
Copy Markdown
Author

coderabbitai Bot commented Apr 15, 2026

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e34d19a2-c7c5-4e4e-b5e3-bd42b11dfbe8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@Jason2866 Jason2866 merged commit c33539d into develop Apr 15, 2026
1 check passed
@Jason2866 Jason2866 deleted the fix/board-psram-flags branch April 15, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant