feat: auto-install tool-clangd-esp when IDE uses clangd IntelliSense#475
Merged
Conversation
The pioarduino IDE extension now exports PLATFORMIO_IDE_INTELLISENSE_ENGINE as an environment variable. When the value is 'clangd', the platform automatically installs tool-clangd-esp during configure_default_packages(). Espressif's clangd has native Xtensa and ESP RISC-V ISA extension support (xespv, xesploop, xespdsp, etc.) that the upstream clangd lacks, which eliminates unknown-flag errors and improves IntelliSense for ESP32 targets. Amp-Thread-ID: https://ampcode.com/threads/T-019d8c25-963a-728c-8166-76efd9747d60 Co-authored-by: Amp <amp@ampcode.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pioarduino IDE extension now exports
PLATFORMIO_IDE_INTELLISENSE_ENGINEas an environment variable (viapatchOSEnviron()). When its value isclangd, the platform automatically installs thetool-clangd-esppackage duringconfigure_default_packages().How it works
The IDE extension then detects the installed binary at
packages/tool-clangd-esp/esp-clangd/bin/clangdand setsclangd.pathaccordingly.Why
Espressif's clangd has native Xtensa and ESP RISC-V ISA extension support (
xespv,xesploop,xespdsp, etc.) that the upstream clangd lacks. This eliminates unknown-flag errors and greatly improves IntelliSense for all ESP32 targets.Changes
platform.py: Added_configure_clangd_tool()method and call inconfigure_default_packages()src/main.jsin pioarduino-vscode-ide sets the env var