Run ensurepip before pip fallback (uv-created venvs lack pip)#443
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughWhen the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@swoboda1337 Well the change makes sense. Thx! |
When the penv is created by uv, pip is not included. If the external uv fails to install uv into the penv (e.g. timeout), the pip fallback fails with
No module named pip.Fix by running
ensurepipto bootstrap pip before the pip fallback.ensurepipis a Python stdlib module that installs pip from a bundled wheel — no network needed.Related: esphome/esphome#15074
Summary by CodeRabbit