Skip to content

always install gdb tool#422

Merged
Jason2866 merged 1 commit into
developfrom
always_gdb
Mar 10, 2026
Merged

always install gdb tool#422
Jason2866 merged 1 commit into
developfrom
always_gdb

Conversation

@Jason2866
Copy link
Copy Markdown

@Jason2866 Jason2866 commented Mar 10, 2026

Checklist:

  • The pull request is done against the latest develop branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR, more changes are allowed when changing boards.json
  • I accept the CLA

Summary by CodeRabbit

  • Chores
    • Consolidated GDB debugging tools into base toolchain packages for Xtensa and RISC-V microcontroller configurations.
    • Streamlined debug tool provisioning to install OpenOCD and ROM-ELF helpers on demand during debugging.
    • Refined GDB capability detection logic.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 785b2a2c-b712-4b5c-b943-3475a22f2404

📥 Commits

Reviewing files that changed from the base of the PR and between dca0a8e and 072b22c.

📒 Files selected for processing (1)
  • platform.py

📝 Walkthrough

Walkthrough

This PR reorganizes MCU toolchain configuration by promoting GDB tools from separate debug_tools entries into the base toolchains list for xtensa and riscv architectures. The GDB detection logic is updated to reflect this structural change.

Changes

Cohort / File(s) Summary
Toolchain and debug tool restructuring
platform.py
Updated MCU_TOOLCHAIN_CONFIG to include GDB tools in base toolchains instead of separate debug_tools entries. Modified _gdb_has_python to detect GDB by filtering toolchains, and updated _configure_mcu_toolchains to install OpenOCD/ROM-ELF as additional debug tools when needed.

Possibly related PRs

Poem

🐰 The tools once scattered, now consolidated bright,
GDB joins the toolchain in a simpler sight,
No more separate debug paths to untangle and mend,
Just streamlined configuration, a rabbit's delight! ✨

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'always install gdb tool' directly describes the main change: GDB is now included in base toolchains and installed as part of standard setup instead of being in separate debug_tools.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch always_gdb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Jason2866
Copy link
Copy Markdown
Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 10, 2026

✅ Actions performed

Full review triggered.

@Jason2866 Jason2866 merged commit ff90519 into develop Mar 10, 2026
1 check passed
@Jason2866 Jason2866 deleted the always_gdb branch March 10, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant