Skip to content

Update IDF 5.5.2.260226#385

Merged
Jason2866 merged 4 commits into
developfrom
test
Feb 9, 2026
Merged

Update IDF 5.5.2.260226#385
Jason2866 merged 4 commits into
developfrom
test

Conversation

@Jason2866
Copy link
Copy Markdown

@Jason2866 Jason2866 commented Feb 9, 2026

Description:

Fix support for ESP32-P4 rev3.x

Checklist:

  • The pull request is done against the latest develop branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR, more changes are allowed when changing boards.json
  • I accept the CLA

Summary by CodeRabbit

  • Chores

    • Updated ESP-IDF framework version to v5.5.2.260206
  • Bug Fixes

    • Enhanced ESP32-P4 variant support with improved linker script and bootloader configuration handling

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 9, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Introduces ESP32-P4 variant support in ESP-IDF build configuration, adding revision-based compatibility flags and variant-aware linker script selection. Updates framework version URL to latest patch release.

Changes

Cohort / File(s) Summary
ESP32-P4 Variant Handling
builder/frameworks/espidf.py
Adds chip_variant checks for ESP32-P4 to generate revision-specific CONFIG flags, select appropriate linker scripts (sections.rev3.ld.in for ESP32-P4, sections.ld.in for others), and choose bootloader linker templates (bootloader.rev3.ld.in when available). Preprocessor paths now variant-aware for framework versions > 5.2.
Framework Version Bump
platform.json
Updates ESP-IDF framework-espidf package version URL from v5.5.2.260116 to v5.5.2.260206.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 P4 revisions hop with care,
Linker scripts now matched per pair,
Bootloader knows its way so true,
Firmware freshly bumped to brew!

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions 'Update IDF 5.5.2.260226' but the actual changes show version 5.5.2.260206, not 260226. Additionally, the title doesn't capture the main feature—ESP32-P4 rev3 support—which the PR description identifies as the primary objective. Update the title to accurately reflect both the correct version number (5.5.2.260206) and the main feature (ESP32-P4 rev3 support), e.g., 'Update IDF to 5.5.2.260206 and fix ESP32-P4 rev3 support'.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Jason2866
Copy link
Copy Markdown
Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 9, 2026

✅ Actions performed

Full review triggered.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@builder/frameworks/espidf.py`:
- Around line 478-487: The print call inside the chip_variant handling block
(where chip_variant == "esp32p4_es" and board_config_flags is appended) uses an
unnecessary f-string; remove the leading "f" so the string is a normal literal
(change the print in the esp32p4_es branch that currently prints f"Info:
Detected ESP32-P4 ES variant, applying revision-based compatibility flags" to a
plain string) to satisfy Ruff F541 and static analysis while leaving the rest of
the board_config_flags appends and logic in the same function/block unchanged.

Comment thread builder/frameworks/espidf.py
@Jason2866 Jason2866 merged commit ec5a9fd into develop Feb 9, 2026
131 of 141 checks passed
@Jason2866 Jason2866 deleted the test branch February 9, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant