feat: Add current_user variable and slugify filter to Jinja #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baumandm
force-pushed
the
external/jinja-current-user
branch
from
3e3078c
to
965c660
Compare
czgu
reviewed
Aug 13, 2024
| @@ -315,7 +326,7 @@ def get_templated_query_variables(variables_provided, jinja_env): | |||
|
|
|||
|
|
|||
| def render_templated_query( | |||
| query: str, variables: Dict[str, str], engine_id: int, session=None | |||
| query: str, variables: Dict[str, str], engine_id: int, uid: int, session=None | |||
There was a problem hiding this comment.
Suggested change
| query: str, variables: Dict[str, str], engine_id: int, uid: int, session=None | |
| query: str, variables: Dict[str, str], engine_id: int, uid: Optional[int] = None, session=None |
| @@ -164,12 +168,19 @@ def get_latest_partition( | |||
| return get_latest_partition | |||
|
|
|||
|
|
|||
| def get_templated_query_env(engine_id: int, session=None): | |||
| def get_templated_query_env(engine_id: int, user: User, session=None): | |||
There was a problem hiding this comment.
Suggested change
| def get_templated_query_env(engine_id: int, user: User, session=None): | |
| def get_templated_query_env(engine_id: int, user: Optional[User], session=None): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new Jinja predefined variables, as well as a custom
slugifyfilter using thepython-slugifypackage.{{ current_user }}: Renders the current user's username{{ current_user_email }}: Renders the current user's email address{{ ... | slugify }}: Transforms the input into a slugified version with underscores, stripping spaces, Unicode, and special characters. This is suitable for generating table / column names dynamically, among other uses.This works both ad hoc and in scheduled Data Docs. I updated the Template Guide documentation, and added additional test cases.