Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: show last updated if untitled doc #1247

Merged
merged 4 commits into from
May 13, 2023
Merged

Conversation

meowcodes
Copy link
Contributor

@meowcodes meowcodes commented May 10, 2023

Screenshot 2023-05-12 at 5 16 24 PM

@meowcodes meowcodes requested review from czgu and jczhong84 May 10, 2023 22:15
Copy link
Collaborator

@jczhong84 jczhong84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not show it for all datadocs, instead of untitled docs only?

also, can we have a shorter version, e.g. 20m ago 1d ago, to save more space for longer titles.

@meowcodes
Copy link
Contributor Author

we can do it for other datadocs in another pr if we want.

@meowcodes meowcodes merged commit 9e4afca into pinterest:master May 13, 2023
@meowcodes meowcodes deleted the date branch May 13, 2023 00:57
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants