fix: str_to_bool and sql-limiter (#1489)

* fix: str_to_bool and sql-limiter * comments
pinterest · Aug 23, 2024 · 8a53387 · 8a53387
1 parent 7419b12
commit 8a53387
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/querybook/server/lib/utils/utils.py b/querybook/server/lib/utils/utils.py
@@ -162,5 +162,8 @@ def get_default_args(func):
     }
 
 
-def str_to_bool(value: Union[str, bool]):
-    return value.lower() in (True, "yes", "true", "t", "1")
+def str_to_bool(value: Optional[str]) -> bool:
+    if value is None:
+        return False
+
+    return value.lower() in ("yes", "true", "t", "1")
diff --git a/querybook/webapp/lib/sql-helper/sql-limiter.ts b/querybook/webapp/lib/sql-helper/sql-limiter.ts
@@ -25,7 +25,7 @@ export function getSelectStatementLimit(
     language?: string
 ): Nullable<number> {
     const tokens = tokenize(statement, { language });
-    const parsedStatement = simpleParse(tokens)[0];
+    const parsedStatement = simpleParse(tokens)?.[0] ?? [];
 
     // Strip nested statements out of the query
     const outerStatement: IToken[] = [];