Add Username + Password Authentication for Trino Client (fixes #829) (#…

…1315) * Add Username + Password Authentication for Trino Client (fixes #829) * Making trino authentication backwards compatible * Removing duplicate connection code
pinterest · Aug 25, 2023 · 814781e · 814781e
1 parent b39d358
commit 814781e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/querybook/server/lib/query_executor/clients/trino.py b/querybook/server/lib/query_executor/clients/trino.py
@@ -52,6 +52,7 @@ def __init__(
         self,
         connection_string: str,
         username: Optional[str] = None,
+        password: Optional[str] = None,
         proxy_user: Optional[str] = None,
         *args: Any,
         **kwargs: Any,
@@ -61,12 +62,17 @@ def __init__(
         host = trino_conf.host
         port = 8080 if not trino_conf.port else trino_conf.port
 
+        auth = trino.constants.DEFAULT_AUTH
+        if username is not None and password is not None:
+            auth = trino.auth.BasicAuthentication(username, password)
+
         connection = trino.dbapi.connect(
             host=host,
             port=port,
             catalog=trino_conf.catalog,
             schema=trino_conf.schema,
-            user=proxy_user or username,
+            auth=auth,
+            user=proxy_user if proxy_user else username,
             http_scheme=trino_conf.protocol,
         )
         self._connection = connection

diff --git a/querybook/server/lib/query_executor/executor_template/templates.py b/querybook/server/lib/query_executor/executor_template/templates.py
@@ -73,7 +73,7 @@
         ),
     ),
     ("username", FormField(regex="\\w+")),
-    ("impersonate", FormField(field_type=FormFieldType.Boolean)),
+    ("password", FormField(hidden=True)),
     (
         "proxy_user_id",
         FormField(