Start to add type hints #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparise
reviewed
Aug 18, 2022
| def set( | ||
| self, | ||
| key: KeyInputSpec, | ||
| value: Any, |
There was a problem hiding this comment.
I'd like to have some constraints on value, but that might need to wait until we have more typing machinery in place for the serde interface.
jogo
force-pushed
the
types
branch
2 times, most recently
from
7bfd63a
to
0b3bd4f
Compare
First pass at adding some type hints to pymemcache to make it easier to develop against etc.
jparise
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at adding some type hints to pymemcache to make it easier to
develop against etc.