Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed HashClient.{get,set}_many() with UNIX sockets. #315

Merged
merged 1 commit into from
May 10, 2021

Conversation

ngnpope
Copy link
Contributor

@ngnpope ngnpope commented May 7, 2021

Overlooked when UNIX socket support was added to HashClient in
acd962b.

Fixes #314.

@ngnpope ngnpope requested review from cgordon, jogo and jparise as code owners May 7, 2021 19:26
@ngnpope ngnpope force-pushed the fix-unix-get-set-many branch from 1990350 to 1c46d5d Compare May 7, 2021 19:28
@ngnpope
Copy link
Contributor Author

ngnpope commented May 7, 2021

@jparise @bombedhair Hopefully this solves the problem.

pymemcache/client/hash.py Outdated Show resolved Hide resolved
Overlooked when UNIX socket support was added to `HashClient` in
acd962b.

Fixes pinterest#314.
@ngnpope ngnpope force-pushed the fix-unix-get-set-many branch from 1c46d5d to 1b471a6 Compare May 10, 2021 17:18
Copy link
Collaborator

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

@jparise jparise merged commit 1505117 into pinterest:master May 10, 2021
@ngnpope ngnpope deleted the fix-unix-get-set-many branch May 10, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when calling 'get_many' on HashClient with Unix socket location
2 participants