Missing @SerializedName annotation on integer-based enums #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicoYao
commented
Nov 14, 2019
| @@ -379,7 +379,7 @@ public struct JavaIR { | |||
| case let .integer(values): | |||
| let names = values | |||
| .map { ($0.description, $0.defaultValue) } | |||
| .map { "\($0.0.uppercased())(\($0.1))" }.joined(separator: ", \n") | |||
| .map { "@\(JavaAnnotation.serializedName(name: "\($0.1)").rendered) \($0.0.uppercased())(\($0.1))" }.joined(separator: ", \n") | |||
There was a problem hiding this comment.
I think it may have just been an oversight that the annotation wasn't added here. On line 400, we have this annotation for string-based enums.
techeretic
approved these changes
Nov 14, 2019
jparise
added a commit
to jparise/plank
that referenced
this pull request
Jan 3, 2020
This was accidentally introduced as part of pinterest#253.
jparise
added a commit
that referenced
this pull request
Jan 3, 2020
This was accidentally introduced as part of #253.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.