Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check _bits directly in internal calls #242

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

jparise
Copy link
Contributor

@jparise jparise commented Aug 27, 2019

Avoid calling our generated get{Foo}IsSet() methods from within the
Builder's methods because we have access to the models' _bits array.

This saves the method call and, in most cases, removes the only caller
of those methods, allowing them to be potentially stripped out from the
final build artifact if they're otherwise unused.

@jparise jparise requested a review from RicoYao August 27, 2019 22:28
Avoid calling our generated get{Foo}IsSet() methods from within the
Builder's methods because we have access to the models' _bits array.

This saves the method call and, in most cases, removes the only caller
of those methods, allowing them to be potentially stripped out from the
final build artifact if they're otherwise unused.
@jparise jparise merged commit a27b144 into pinterest:master Aug 28, 2019
@jparise jparise deleted the java-bits-inline branch August 28, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants