Only allocate _bits when necessary #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicoYao
reviewed
Aug 23, 2019
We were previously allocating the _bits array as part of its declaration. In many cases, we wouldn't use this memory; we would just reassign _bits in the non-default constructors and builders. Instead, we now only allocate _bits in the default Builder constructor. We also now generate a default public model constructor when package- private setters are enabled so that there's some backing storage to support those set methods. (Note that we don't currently appear to actually update _bits in those methods, which may be a separate issue.) Lastly, we no longer need to read the "_bits" array in TypeAdapter#read, so remove that case entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously allocating the _bits array as part of its
declaration. In many cases, we wouldn't use this memory; we would
just reassign _bits in the non-default constructors and builders.
Instead, we now only allocate _bits in the default Builder constructor.
We also now generate a default public model constructor when package-
private setters are enabled so that there's some backing storage to
support those set methods. (Note that we don't currently appear to
actually update _bits in those methods, which may be a separate issue.)
Lastly, we no longer need to read the "_bits" array in TypeAdapter#read,
so remove that case entirely.