Add option to generate Java private setters #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-malik
approved these changes
May 31, 2019
|
@RicoYao any changes coming before I should merge? |
|
@rahul-malik I think I'll put in the experimental flag on this first as discussed. Thanks. |
Plank models should be immutable, but certain project configurations may require that models have setters that can be accessed package-privately.
|
Updated cli flag to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plank models should be immutable, but certain project configurations may require that models have
setters that can be accessed package-privately.
Added as a custom command line option. By default, the setters will not be added.
Example:
plank --lang=java --java_generate_package_private_setters_beta my_model.json