Use smaller enum types to reduce object sizes.

[bolsinga]

If a model has lots of enums, making them smaller instead of 64-bit NSInteger types will help. Apple only uses 64-bit enums since they need to guarantee binary compatibility for years, even after they add new enum values. Since this is generated source and re-compiled into applications, this does not apply.

Pinterest builds with -Werror -Wconversion. This means the -decodeIntegerForKey: needs a cast to the enumeration type name. Same goes for -initWithModelDictionary:.

This is only applicable to ObjC, since it is the place where these C types will save some space.

[jparise]

👍 from me.

@rahul-malik made some good comments, and I defer to him on the final sign-off.

[rahul-malik]

Here is the conflict since GH isn't loading it...

 +    public static final String TYPE = "everything";
++=======
+     public enum EverythingUnsignedCharEnum {
+         UNSIGNED_CHAR_CASE_2(255);
+         private final int value;
+         EverythingUnsignedCharEnum(int value) {
+             this.value = value;
+         }
+         public int getValue() {
+             return this.value;
+         }
+     }
+
+     public enum EverythingUnsignedIntEnum {
+     public enum EverythingUnsignedIntEnum {
+         UNSIGNED_INT_CASE_2(65536);
+         private final int value;
+         EverythingUnsignedIntEnum(int value) {
+             this.value = value;
+         }
+         public int getValue() {
+             return this.value;
+         }
+     }
+
+     public enum EverythingUnsignedShortEnum {
+         CHAR_CASE_2(256);
+         private final int value;
+         EverythingUnsignedShortEnum(int value) {
+             this.value = value;
+         }
+         public int getValue() {
+             return this.value;
+         }
+     }
++>>>>>>> 922ead267767c04087c3c20e43a7323b17bdb8eb```

[bolsinga]

Here is the conflict since GH isn't loading it...

 +    public static final String TYPE = "everything";
++=======
+     public enum EverythingUnsignedCharEnum {
+         UNSIGNED_CHAR_CASE_2(255);
+         private final int value;
+         EverythingUnsignedCharEnum(int value) {
+             this.value = value;
+         }
+         public int getValue() {
+             return this.value;
+         }
+     }
+
+     public enum EverythingUnsignedIntEnum {
+     public enum EverythingUnsignedIntEnum {
+         UNSIGNED_INT_CASE_2(65536);
+         private final int value;
+         EverythingUnsignedIntEnum(int value) {
+             this.value = value;
+         }
+         public int getValue() {
+             return this.value;
+         }
+     }
+
+     public enum EverythingUnsignedShortEnum {
+         CHAR_CASE_2(256);
+         private final int value;
+         EverythingUnsignedShortEnum(int value) {
+             this.value = value;
+         }
+         public int getValue() {
+             return this.value;
+         }
+     }
++>>>>>>> 922ead267767c04087c3c20e43a7323b17bdb8eb```

Everything is additive, and the code changes both add code to the same location in the generated file. Is there a proper way to rebase this diff on top of master to get those TYPE changes?

[rahul-malik]

Doesn't make integration_test regenerate the file for you?

[bolsinga]

Doesn't make integration_test regenerate the file for you?

After running that, my repository is clean. I do not know how to proceed here. I verified that this branch is up-to-date with origin/master (it has bdd00b0). I run all the make commands and everything appears to be clean.

What code currently (or used to) generate the following? I can't seem to figure this out.

public static final String TYPE = "everything";

[bolsinga]

Doesn't make integration_test regenerate the file for you?

After running that, my repository is clean. I do not know how to proceed here. I verified that this branch is up-to-date with origin/master (it has bdd00b0). I run all the make commands and everything appears to be clean.

What code currently (or used to) generate the following? I can't seem to figure this out.

public static final String TYPE = "everything";

aha i needed to merge an upstream branch, not my fork's master. :|