Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing comma in Java model constructor #175

Merged

Conversation

RicoYao
Copy link
Contributor

@RicoYao RicoYao commented Mar 8, 2019

No description provided.

@rahul-malik
Copy link
Collaborator

Oh nice! I can remove this from this PR #176

@RicoYao
Copy link
Contributor Author

RicoYao commented Mar 8, 2019

oh didn't realize you already had that going. Feel free to disregard my fix if that's simpler.

I don't have permissions to merge, so just go with whatever's easier.

@rahul-malik rahul-malik merged commit f38aa84 into pinterest:master Mar 8, 2019
@rahul-malik
Copy link
Collaborator

I’ll merge this over my commit. my commit doesn’t conflict and I was just working through issues to get the code to build.

I expect my PR to be more around the actual build scripting / CI changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants