Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set disabled_rules in userData if not empty #539

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Only set disabled_rules in userData if not empty #539

merged 1 commit into from
Jul 23, 2019

Conversation

shashachu
Copy link
Contributor

Fixes #538

@shashachu shashachu merged commit f7fc4eb into pinterest:master Jul 23, 2019
idntfy
idntfy reviewed Jul 23, 2019
View reviewed changes
Copy link

@idntfy idntfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think tests will catch issues like this one (referring to #540)

@shashachu shashachu deleted the fix-disabled-rules branch August 2, 2019 22:16
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Aug 31, 2019
@shashachu @sowmyav24
Only set disabled_rules in userData if not empty (pinterest#539)
12232bb 
Fixes pinterest#538
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Aug 31, 2019
@shashachu @sowmyav24
Only set disabled_rules in userData if not empty (pinterest#539)
805eeb6 
Fixes pinterest#538
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Sep 3, 2019
@shashachu
Only set disabled_rules in userData if not empty (pinterest#539)
0ffb71b 
Fixes pinterest#538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idntfy idntfy idntfy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.editorconfig disabled_rules field not being honoured
2 participants
@shashachu @idntfy