Masonry: Update fullWidthLayout to not floor column widths #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertCarreras
approved these changes
Nov 15, 2024
✅ Deploy Preview for gestalt ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when calculating column widths via
fullWidthLayout, the values of the column widths are rounded down via Math.floor.Because we rely on CSS (specifically
calc) for the initial server render, this can actually cause slight layout shifts when going from server render -> client render due to the slight difference in widthsWhile visually, this is not an issue (due to the shift being so tiny), this can actually result in LCP regressions since this results in a repaint.
This PR addresses the issue by removing the Math.floor. After this change, the column width will stay consistent between server and client render