Exclude node_modules from babelification #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btraut
commented
Sep 26, 2018
CHANGELOG.md
Outdated
| @@ -42,7 +43,7 @@ | |||
| ### Minor | |||
|
|
|||
| - Button: Fix transparent button on blue background (#316) | |||
| - Flyout: Add new prop `shouldFocus` to override focus on open behavior. *Has codemod* (#325) | |||
There was a problem hiding this comment.
Oops, this is an accident. My VS Code insists on formatting to use _ instead of *.
|
Deploy preview for gestalt ready! Built with commit 524fce4 |
|
Deploy preview for gestalt ready! Built with commit d1e6e41 |
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 72.58% 72.58%
=======================================
Files 57 57
Lines 1109 1109
Branches 265 265
=======================================
Hits 805 805
Misses 221 221
Partials 83 83Continue to review full report at Codecov.
|
christianvuerings
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to add
react-virtualizedin my Masonry9 branch, I ran into issues where the test package would explode. Turns out, it was trying to babelify all node_modules. This PR excludes node_modules in both the Gestalt package and test.See exact problem and recommended solution here:
bvaughn/react-virtualized#1112