Added SPM support #283
Merged
Added SPM support #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a4oT
commented
Sep 14, 2020
|
This would be fantastic if this got merged! :) |
|
@garrettmoon ping... |
garrettmoon
reviewed
Sep 29, 2020
garrettmoon
reviewed
Sep 29, 2020
|
@garrettmoon, I've addressed your feedback. Thanks! |
|
@garrettmoon This seems to be a sporadic failure, I can confirm that from time to time the same test fails locally. Can we trigger tests again? |
garrettmoon
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SPM support starting from Swift 5.3 (since it supports resources). Some notes:
SPM tests not passing when you run it from a command line (SPM(bug)? gets the wrong bundle path) but passing if you use Xcode in SPM edit mode(just open as a package instead of .xcodeproj).
dependency strategy for
PINOperationset as - branchmaster. I believe it should be set - fromPINOperation 1.2.0but unfortunately, it was tagged as1.2and SPM can not resolve it. Can the maintainers re-tag/new it with proper sem-ver?