Improve performance of age limit trimming #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
This does two things: 1. Before this patch, PINCache was naively scheduling a task to trim to age limit *recursively* every time the age limit was set. This makes it so recursive calls are canceled when it detects another recursive call has been kicked off. This is still less than ideal :/ 2. Trimming (mistakenly) used to be a high priority task. Now the age limit itself is set with a high priority, but the trimming is done at a low priority.
garrettmoon
force-pushed
the
improveDateTrimmingPerformance
branch
from
2c2072c to
9200a55
Compare
|
🚫 CI failed with log |
|
🚫 CI failed with log |
nguyenhuy
approved these changes
Jun 7, 2018
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
Thanks for the improvements! My team is now starting to use this at scale,
so any optimizations will be put to broad use :)
…On Thu, Jun 7, 2018 at 12:05 PM Pinterest Bot ***@***.***> wrote:
🚫 CI failed with log
<https://gist.githubusercontent.com/pinterest-ios/be67a6fa8c5af96b002dd88a54cd8cf7/raw/36bf14035b808d53ae4a842482054486865259ad/log.txt>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#224 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAigA6iHVjlflVlTXxcRD7paeKxFbrLYks5t6XlygaJpZM4Ue0l6>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things: