Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set some sane limits on the disk cache for people who forget. #201

Merged
merged 4 commits into from
Oct 1, 2017

Conversation

garrettmoon
Copy link
Collaborator

No description provided.

@ghost
Copy link

ghost commented Sep 29, 2017

🚫 CI failed with log

Copy link
Contributor

@appleguy appleguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement - most users will either set a default directly (including 0 if they want that), or otherwise this default should serve them reasonably well for both relatively large and small storage cases.

@garrettmoon garrettmoon merged commit 7dc9b30 into master Oct 1, 2017
@sjtupt
Copy link

sjtupt commented Dec 19, 2018

why add limit to disk cache? And 50M is too little for disk cache?

@garrettmoon
Copy link
Collaborator Author

@sjtupt We decided to set a default limit because Apple shows caches in the settings screen for how much space an app is using. So with no limit this can surprise some users as to why an app is using up so much disk space. You can always set a higher or infinite limit for your app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants