Check fileURL outside of the locked scope (#262)

We can exit immediately when fileURL is invalid without acquiring and then releasing the write lock.
pinterest · Mar 2, 2020 · b32bd0a · b32bd0a
1 parent 91fd8d0
commit b32bd0a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/Source/PINDiskCache.m b/Source/PINDiskCache.m
@@ -666,10 +666,13 @@ - (BOOL)_locked_setAgeLimit:(NSTimeInterval)ageLimit forURL:(NSURL *)fileURL
 - (BOOL)removeFileAndExecuteBlocksForKey:(NSString *)key
 {
     NSURL *fileURL = [self encodedFileURLForKey:key];
-
+    if (!fileURL) {
+        return NO;
+    }
+
     // We only need to lock until writable at the top because once writable, always writable
     [self lockForWriting];
-        if (!fileURL || ![[NSFileManager defaultManager] fileExistsAtPath:[fileURL path]]) {
+        if (![[NSFileManager defaultManager] fileExistsAtPath:[fileURL path]]) {
             [self unlock];
             return NO;
         }