Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #23

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Update docs #23

merged 2 commits into from
Oct 31, 2022

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Aug 6, 2022 •
edited
Loading

Why I did it

@mdanish-kh mdanish-kh changed the title Update URLs from Azure to sonic-net Update docs Aug 20, 2022
@mdanish-kh
Copy link
Contributor Author

@smolkaj @pudelkoM Can you please review this?

smolkaj
smolkaj approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@smolkaj smolkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdanish-kh
Copy link
Contributor Author

LGTM

@smolkaj Can we merge this?

@smolkaj
Copy link
Member

smolkaj commented Sep 8, 2022

I kicked of the CI run.
@pudelkoM can you take another look and merge? I am not authorized.

@pudelkoM
Copy link

pudelkoM commented Sep 8, 2022

I can take a look, but I'm also not authorized to merge. Maybe @bocon13 can help here?

@mdanish-kh
Copy link
Contributor Author

mdanish-kh commented Sep 18, 2022 •
edited
Loading

Maybe @mint570 @bhagatyj @donNewtonAlpha can help with the merge process as well.

@mint570
Copy link

mint570 commented Sep 28, 2022

Looks good to me.
@pudelkoM does this PR look good to you?

@mint570 mint570 merged commit ba42a5f into pins:main Oct 31, 2022
@mdanish-kh mdanish-kh deleted the fix-sonic-links branch October 31, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smolkaj smolkaj smolkaj approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdanish-kh @smolkaj @pudelkoM @mint570