Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9744] Fix collector starter behaviors by arguments #9747

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Mar 3, 2023

No description provided.

@smilu97 smilu97 requested review from ga-ram and emeroad March 3, 2023 08:28
@smilu97 smilu97 linked an issue Mar 3, 2023 that may be closed by this pull request
@smilu97 smilu97 self-assigned this Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #9747 (cdc1221) into master (ed34f41) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #9747      +/-   ##
============================================
- Coverage     38.80%   38.79%   -0.01%     
+ Complexity    11914    11912       -2     
============================================
  Files          3512     3512              
  Lines         94074    94082       +8     
  Branches      10530    10530              
============================================
- Hits          36507    36501       -6     
- Misses        54393    54403      +10     
- Partials       3174     3178       +4     
Impacted Files Coverage Δ
...t/common/server/env/AdditionalProfileListener.java 0.00% <0.00%> (ø)
...p/pinpoint/common/server/starter/BasicStarter.java 0.00% <0.00%> (ø)
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 70.83% <0.00%> (-8.34%) ⬇️
...ollector/cluster/zookeeper/ZookeeperJobWorker.java 78.07% <0.00%> (-1.61%) ⬇️
...n/server/bo/serializer/trace/v2/SpanEncoderV0.java 82.88% <0.00%> (-0.54%) ⬇️
...n/server/bo/serializer/trace/v2/SpanDecoderV0.java 81.27% <0.00%> (-0.46%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 72.22% <0.00%> (ø)
...tor/metric/datasource/DefaultDataSourceMetric.java 88.88% <0.00%> (+3.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@smilu97 smilu97 merged commit 8450a69 into pinpoint-apm:master Mar 7, 2023
@smilu97 smilu97 deleted the 9744_collector_starter branch March 7, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix collector starter to import all configs by default
1 participant