Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11497] Fix DirectByteBuffer leak in active thread count #11529

Merged

Conversation

jaehong-kim
Copy link
Contributor

@jaehong-kim jaehong-kim added this to the 3.0.1 milestone Sep 26, 2024
@jaehong-kim jaehong-kim self-assigned this Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 44 lines in your changes missing coverage. Please review.

Project coverage is 37.05%. Comparing base (c540794) to head (d9a305e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...me/collector/receiver/grpc/GrpcCommandService.java 47.36% 10 Missing ⚠️
.../grpc/ActiveThreadCountResponseStreamObserver.java 61.90% 4 Missing and 4 partials ⚠️
...sink/ActiveThreadCountPublisherSinkRepository.java 0.00% 6 Missing ⚠️
...me/collector/sink/RealtimeCollectorSinkConfig.java 0.00% 4 Missing ⚠️
.../realtime/collector/sink/SimpleSinkRepository.java 20.00% 4 Missing ⚠️
...ime/collector/sink/ActiveThreadCountPublisher.java 78.57% 3 Missing ⚠️
...er/receiver/grpc/GrpcActiveThreadCountService.java 0.00% 2 Missing ⚠️
...time/collector/sink/ActiveThreadDumpPublisher.java 71.42% 2 Missing ⚠️
...collector/sink/ActiveThreadLightDumpPublisher.java 71.42% 2 Missing ⚠️
...inpoint/realtime/collector/sink/EchoPublisher.java 71.42% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11529      +/-   ##
============================================
- Coverage     37.05%   37.05%   -0.01%     
- Complexity    12217    12225       +8     
============================================
  Files          4035     4039       +4     
  Lines         98935    98976      +41     
  Branches      10433    10436       +3     
============================================
+ Hits          36665    36677      +12     
- Misses        59288    59316      +28     
- Partials       2982     2983       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaehong-kim jaehong-kim merged commit c2785d6 into pinpoint-apm:master Sep 27, 2024
3 checks passed
@jaehong-kim jaehong-kim deleted the fix-collector-realtime-close-2 branch September 27, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant