Added the ability to build a transport using a transform #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1290626233Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jsumners
approved these changes
Sep 29, 2021
README.md
Outdated
| @@ -97,6 +101,40 @@ module.exports = function (opts) { | |||
| } | |||
| ``` | |||
|
|
|||
| ### Stream concatenation / pipeline | |||
|
|
|||
| You can pipeline multiple transport as well. | |||
There was a problem hiding this comment.
Suggested change
| You can pipeline multiple transport as well. | |
| You can pipeline multiple transports: |
It would be good to link to a concrete (real world) example in the pino-syslog docs when it is implemented.
There was a problem hiding this comment.
I Agree. I'll update the doc once this is implemented fully.
Co-authored-by: James Sumners <[email protected]>
Co-authored-by: James Sumners <[email protected]>
Eomm
approved these changes
Sep 30, 2021
Co-authored-by: Manuel Spigolon <[email protected]>
jsumners
reviewed
Sep 30, 2021
| @@ -51,8 +51,8 @@ Create a [`split2`](http://npm.im/split2) instance and returns it. | |||
| This same instance is also passed to the given function, which is called | |||
| synchronously. | |||
|
|
|||
| If `fn` returns a [`Readable`](https://nodejs.org/api/stream.html#stream_class_stream_readable), we will | |||
| wrap that readable and the split2 instance using [`duplexify`](https://www.npmjs.com/package/duplexify), | |||
| If `opts.transform` is `true`, `pino-abstract-transform` will | |||
There was a problem hiding this comment.
Suggested change
| If `opts.transform` is `true`, `pino-abstract-transform` will | |
| If `opts.enablePipelining` is `true`, `pino-abstract-transform` will |
There was a problem hiding this comment.
Suggested change
| If `opts.transform` is `true`, `pino-abstract-transform` will | |
| If `opts.enablePipelining` is `true`, `pino-abstract-transform` will |
Eomm
reviewed
Sep 30, 2021
| @@ -51,8 +51,8 @@ Create a [`split2`](http://npm.im/split2) instance and returns it. | |||
| This same instance is also passed to the given function, which is called | |||
| synchronously. | |||
|
|
|||
| If `fn` returns a [`Readable`](https://nodejs.org/api/stream.html#stream_class_stream_readable), we will | |||
| wrap that readable and the split2 instance using [`duplexify`](https://www.npmjs.com/package/duplexify), | |||
| If `opts.transform` is `true`, `pino-abstract-transform` will | |||
There was a problem hiding this comment.
Suggested change
| If `opts.transform` is `true`, `pino-abstract-transform` will | |
| If `opts.enablePipelining` is `true`, `pino-abstract-transform` will |
Co-authored-by: Manuel Spigolon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.