Repository navigation
ci(release): darwin-x64 and win32-arm64 without PGO; darwin-x64 on the Blacksmith arm64 Mac - #98
Merged
Merged
Conversation
GitHub's 4 vCPU macos-15-intel took 76 minutes for the three fat-LTO builds of the darwin-x64 tsc (plain 18.5, PGO 53.5). Cross-build it on blacksmith-12vcpu-macos-26, as T3 Code builds its x64 desktop app, and run the x86-64 PGO training and checks under Rosetta 2. The verify job still runs it on macos-15-intel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Their PGO builds took 76 and 48 minutes on 4 vCPU runners. Without PGO each is one fat-LTO build, about 10 to 13% slower on a check (R121: PGO and BOLT used 14 to 15% fewer cycles than plain, BOLT 1.3 to 2.6% of it). The other four platforms keep PGO. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
t3dotgg
changed the title
t3dotgg
added a commit
to DeryFerd/ts-rust
that referenced
this pull request
Oct 22, 2026
Resolves the release.yml conflict with pingdotgg#98: keeps the artifact verify step and main's "main packages" comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two release builds dominate the release time, both on GitHub's 4 vCPU runners, where each does three fat-LTO builds (the plain reference tsc, then the PGO instrumented and final builds with training):
macos-15-intel: 76 minutes (plain 18.5, PGO 53.5). Blacksmith has no Intel Mac.windows-11-arm: 48 minutes. Blacksmith has no arm64 Windows runner.This ships both without PGO, so each job is one fat-LTO build, and cross-builds darwin-x64 on
blacksmith-12vcpu-macos-26, as T3 Code does for its x64 desktop app (pingdotgg/t3code#22264, #22613). Its tsc check runs the x86-64 tsc under Rosetta 2 (a new step installs it if the image lacks it), and the verify job still runs the packed tsc on a real Intel Mac. The other four platforms keep PGO.The cost: about 10 to 13% more CPU on a check on those two platforms (R121, x86-64 Linux: PGO and BOLT used 14 to 15% fewer cycles than plain, 1.3 to 2.6% of it from BOLT, which these builds never had). npm/README.md says so.
The release CI of this PR is the test: the darwin-x64 and win32-arm64 build times show up there.
Made by Claude Opus 5.5 in Claude Code (running in T3 Code).
🤖 Generated with Claude Code