Skip to content

refactor(web): remove unused aspect ratio reconciler #9994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Sep 5, 2026
+1 −19
Merged

refactor(web): remove unused aspect ratio reconciler #9994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions apps/web/src/browser/BrowserDeviceToolbar.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import type { PreviewViewportSetting } from "@t3tools/contracts";
import { describe, expect, it, vi } from "vite-plus/test";

import {
commitViewportAndAspectRatio,
reconcileLockedAspectRatio,
} from "./browserDeviceToolbarState";
import { commitViewportAndAspectRatio } from "./browserDeviceToolbarState";

describe("commitViewportAndAspectRatio", () => {
it("commits the aspect ratio only after the viewport succeeds", async () => {
Expand Down Expand Up @@ -39,11 +36,3 @@ describe("commitViewportAndAspectRatio", () => {
expect(onAspectRatioChange).not.toHaveBeenCalled();
});
});

describe("reconcileLockedAspectRatio", () => {
it("tracks external viewport ratios only while the lock remains active", () => {
expect(reconcileLockedAspectRatio(1.5, 16 / 9)).toBe(16 / 9);
expect(reconcileLockedAspectRatio(null, 16 / 9)).toBeNull();
expect(reconcileLockedAspectRatio(1.5, null)).toBeNull();
});
});
7 changes: 0 additions & 7 deletions apps/web/src/browser/browserDeviceToolbarState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,5 @@
import type { PreviewViewportSetting } from "@t3tools/contracts";

export function reconcileLockedAspectRatio(
current: number | null,
viewportAspectRatio: number | null,
): number | null {
return current === null || viewportAspectRatio === null ? null : viewportAspectRatio;
}

export async function commitViewportAndAspectRatio(
setting: PreviewViewportSetting,
aspectRatio: number | null,
Expand Down
Loading