refactor(client-runtime): remove unused file position predicate - #9976
Effect Service Conventions: No issues found
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
The PR removes the unused exported helper isConventionalFilePosition and its BARE_EXTENSIONLESS_POSITION_PATTERN constant from packages/client-runtime/src/markdownLinks.ts, plus the corresponding test block (out of scope per exclude pattern **/*.test.ts).
In-scope changed file: packages/client-runtime/src/markdownLinks.ts. It contains pure string/regex helpers with no Effect services, layers, tags, or error classes, so none of the Effect service conventions (imports/namespaces, service definition ordering, dependency acquisition, runtime boundaries, tagged errors) apply. Verified there are no remaining references to the removed identifiers, so no consumers or barrel exports were left dangling and no compatibility shim was introduced. The removal is a mechanical dead-code cleanup, so no new tests are required.
🔍 Agent activity — 2 tool calls
💭 This diff just removes a function and its test, so I need to verify isConventionalFilePosition isn't still used elsewhere before confirming it's safe to delete.
1. browse_code — Are there any usages or references to isConventionalFilePosition, BARE_EXTENSIONLESS_POSITION_PATTERN, or EXTENSIONLESS_FILE_NAMES anywhere in the repo (imports, barrels, exports)? List file paths and lines.
2. browse_code — packages/client-runtime/src/markdownLinks.ts
💭 This is just dead code removal in a non-Effect module, so there's nothing related to Effect service conventions here—no findings needed.
Agent Credits: 221 credits
Token usage: 30 uncached input · 1,538,145 cache-read input · 181,721 cache-write input · 7,811 output
Agent Credits may also include non-token charges from external tools such as web research.