Skip to content

fix(terminal): identify T3 Code terminal sessions - #9954

Open
juliusmarminge wants to merge 5 commits into
mainfrom
fix/audit-terminal-identity
Open

juliusmarminge wants to merge 5 commits into
mainfrom
fix/audit-terminal-identity

fix(terminal): identify T3 Code terminal sessions

4884259
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Sep 5, 2026 in 4m 19s

All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — 2 tool calls

💭 I'm checking the change to createTerminalSpawnEnv in Manager.ts, which sets TERM_PROGRAM and a version pulled from package.json — wondering if importing package.json directly breaks Effect's usual service conventions.

1. browse_code — Show the full body of function createTerminalSpawnEnv in apps/server/src/terminal/Manager.ts, plus its surrounding context and callers, and the import block at the top of the file.

2. browse_code — How is the app version accessed elsewhere in apps/server and packages? Is there an existing service, constant, or config module (e.g. version.ts, AppVersion, packageJson import) used to read the package version? List examples with file paths.

💭 The change looks minor and consistent with existing repo conventions—just setting env vars with a JSON import matching established patterns, with tests already added covering the override ordering. This looks clean with no Effect convention issues, so I should respond with the exact "All clear" format as instructed.


Agent Credits: 218 credits

Token usage: 46 uncached input · 987,964 cache-read input · 186,903 cache-write input · 16,300 output
Agent Credits may also include non-token charges from external tools such as web research.