fix(web): stop empty diffs replacing pull requests - #9753
Effect Service Conventions: No issues found
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Only apps/web/src/components/ChatView.logic.ts fell within this check's scope (apps/**/*.ts, packages/**/*.ts, infra/**/*.ts, excluding **/*.test.ts). The change adds a pure synchronous helper, resolveProactiveTurnDiffAction, that reads a checkpoint summary, a git-repo flag, and the active right-panel surface kind and returns a "defer" | "ignore" | "open" decision. It introduces no Effect service definition, no layer or tag, no error types, no dependency acquisition, and no runtime boundary calls, so no Effect service conventions apply. The remaining changed files (ChatView.tsx, SettingsPanels.tsx, ChatView.logic.test.ts, docs/user/source-control.md) are out of scope and were used only as context.
🔍 Agent activity — 1 tool call
💭 Checking the diff, only ChatView.logic.ts falls within scope since the test file is excluded and the .tsx/docs files don't match the pattern. The added function looks like a pure helper with no Effect service involvement, so I'm leaning toward "all clear" but want to double-check the file for anything Effect-related first.
1. browse_code — apps/web/src/components/ChatView.logic.ts
💭 No Effect service concerns here, everything looks fine.
Agent Credits: 15 credits
Token usage: 4 uncached input · 14,376 cache-read input · 17,447 cache-write input · 798 output
Agent Credits may also include non-token charges from external tools such as web research.