Skip to content

fix(web): fold single trailing activity - #9739

Merged
maria-rcks merged 3 commits into
pingdotgg:mainfrom
maria-rcks:t3code/collapse-single-comments
Sep 4, 2026
Merged

maria-rcks merged 3 commits into
pingdotgg:mainfrom
maria-rcks:t3code/collapse-single-comments

test(web): minimize trailing activity coverage

4c785d5
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Sep 4, 2026 in 2m 15s

Effect Service Conventions: No issues found

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

The only in-scope changed file is apps/web/src/components/chat/MessagesTimeline.logic.ts (test files are excluded by check configuration). The change adds a isSingleTrailingActivity condition to deriveTurnFolds, pure client-side timeline derivation logic with no Effect service definition, layer, error class, runtime boundary, or dependency acquisition. The Effect service conventions do not apply to these lines, and the change is accompanied by updated logic tests.


🔍 Agent activity — 2 tool calls

💭 The diff touches MessagesTimeline.logic.ts, which is React chat timeline logic rather than an Effect service, so I doubt there are any Effect convention violations here. I'll peek at the file just to confirm there's no Effect involvement.

1. browse_code — apps/web/src/components/chat/MessagesTimeline.logic.ts

2. browse_code — apps/web/src/components/chat/MessagesTimeline.logic.ts

💭 This is pure UI logic with no Effect service involvement, so no backend behavior changed here — and since tests were already added, the frontend requirement is satisfied.


Agent Credits: 15 credits

Token usage: 4 uncached input · 13,537 cache-read input · 17,694 cache-write input · 821 output
Agent Credits may also include non-token charges from external tools such as web research.