Skip to content

perf(mobile): keep image bytes outside draft JSON - #9727

Open
t3dotgg wants to merge 3 commits into
mainfrom
t3code/perf-mobile-file-backed-draft-writers
Open

t3dotgg wants to merge 3 commits into
mainfrom
t3code/perf-mobile-file-backed-draft-writers

fix(mobile): validate persisted image names and sizes

ffefa00
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Sep 30, 2026 in 1m 1s

All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — 5 tool calls

1. browse_code — apps/mobile/src/lib/composerImages.ts

2. browse_code — apps/mobile/src/features/sharing/incoming-share-model.ts

💭 These files are plain TypeScript/React Native, not Effect services, so the check only applies when a PR touches Effect service code. I'm checking the other changed files to see which ones fall within scope—thread-outbox-model.ts, composer-image-schema.ts, and ReviewCommentComposerSheet.tsx (though the tsx file is excluded since the include patterns only cover *.ts). The in-scope files I need to check are incoming-share-model.ts, composer-image-schema.ts, composerImages.ts, and thread-outbox-model.ts. I want to verify whether any of these actually involve Effect services—thread-outbox-model.ts does use Schema from effect, so I'm checking its imports more closely.

3. browse_code — apps/mobile/src/state/thread-outbox-model.ts

4. browse_code — apps/mobile/src/lib/composer-image-schema.ts

💭 These files don't create or consume Effect services—imports use proper namespace subpath imports and errors are plain Error objects in a promise-based React Native module, not Effect service errors, so the conventions about Effect services don't apply here. Let me double check by searching for "Effect" across the changed files, especially composerImages.ts, to confirm no runPromise or Effect usage crept in.

5. browse_code — In apps/mobile/src/lib/composerImages.ts, apps/mobile/src/features/sharing/incoming-share-model.ts, and apps/mobile/src/state/thread-outbox-model.ts, are there any imports from "effect" or usages of Effect, Layer, Context.Service, ManagedRuntime, runPromise, or Schema.TaggedErrorClass? List each import statement in those three files.

💭 I don't see any new eslint-disable or ts-expect-error directives introduced in the changed lines, so there are no findings here. Since everything checks out clean, my final response should just be "All clear" on its own line, though I still need to call complete_check with the required fields properly filled in.


Agent Credits: 68 credits

Token usage: 12 uncached input · 122,352 cache-read input · 74,314 cache-write input · 4,533 output
Agent Credits may also include non-token charges from external tools such as web research.