fix(ui): unify loading and refresh feedback across clients - #9561
juliusmarminge merged 6 commits into
UI Consistency: no findings
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/ui-consistency.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed changed lines in apps/web/src/**/*.tsx (no .css files changed). The diff consolidates ad hoc animate-spin lucide icons onto the shared Spinner and the new ~/components/ui/refresh-icon primitive, adds no raw styled controls, no global CSS, no inline static style objects, and no duplicated primitive markup.
🔍 Agent activity — 2 tool calls
💭 I'm checking the new RefreshIcon and Spinner components for consistency with shared primitives, noting the aria-hidden ordering isn't really a styling issue, and confirming ComposerActivityStatus's swap from LoaderCircleIcon to Spinner looks correct. Nothing seems out of scope here — no global CSS changes, and the Spinner usage with toneClassName in pullRequestPresentation looks fine. Both RefreshIcon and Spinner compose the lucide icon similarly without real duplication, and I'm double-checking the ui directory to make sure there isn't already an existing spinner-like component that RefreshIcon overlaps with.
1. browse_code — apps/web/src/components/ui/*.tsx
2. browse_code — apps/web/src/components/ui/spinner.tsx
💭 No CSS changes or raw controls—everything consolidates onto shared primitives, matching the rules. The RefreshIcon ordering of aria-hidden before spread is fine, not a violation. Everything checks out, so I'll mark this as all clear.
Agent Credits: 34 credits
Token usage: 4 uncached input · 41,899 cache-read input · 44,051 cache-write input · 1,099 output
Agent Credits may also include non-token charges from external tools such as web research.