Skip to content

fix(web): keep ref picker steady when opening #9472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 2 commits into from
Sep 7, 2026
+5 −3
Merged

fix(web): keep ref picker steady when opening #9472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f16b49c
fix(web): stabilize single-select popup anchors
Adamulek123 Sep 3, 2026
a862ba8
fix(web): keep ref picker popup steady while pressing trigger
Adamulek123 Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/web/src/components/BranchToolbarBranchSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,9 @@ export function BranchToolbarBranchSelector({
>
<ComboboxTrigger
render={<Button variant="ghost" size="xs" />}
className="min-w-0 max-w-full font-normal text-muted-foreground/70 text-xs! hover:text-foreground/80"
// No press-scale: the popup aligns live to this trigger, so a
// momentary 0.97 shrink would drag the open popup ~3px sideways.
className="min-w-0 max-w-full font-normal text-muted-foreground/70 text-xs! hover:text-foreground/80 active:scale-100"
disabled={isInitialBranchesLoadPending || isBranchActionPending}
>
<GitBranchIcon className="size-3 shrink-0 opacity-70" />
Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/components/ui/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ function ComboboxPopup({
side?: ComboboxPrimitive.Positioner.Props["side"];
anchor?: ComboboxPrimitive.Positioner.Props["anchor"];
}) {
const { chipsRef } = React.use(ComboboxContext);
const anchor = anchorProp ?? chipsRef;
const { chipsRef, multiple } = React.use(ComboboxContext);
const anchor = anchorProp ?? (multiple ? chipsRef : undefined);

return (
<ComboboxPrimitive.Portal>
Expand Down
Loading