Skip to content

fix(desktop): make the annotation editor border and shadow actually render #9406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 3 commits into from
Oct 19, 2026
Merged

fix(desktop): make the annotation editor border and shadow actually render #9406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f23c7a
fix(desktop): make the annotation editor border and shadow actually r…
PollyGlot Sep 3, 2026
cb2f3da
Merge remote-tracking branch 'origin/main' into fix/annotation-editor…
juliusmarminge Oct 19, 2026
35c743c
fix(desktop): fail annotation CSS generation if defaults stay conditi…
juliusmarminge Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apps/desktop/scripts/build-preview-annotation-css.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,16 @@ const compilerInput = [
annotationSource.replace('@import "tailwindcss";', "@tailwind utilities;"),
].join("\n");
const compiler = await compile(compilerInput, { base: appRoot });
const css = compiler.build([...candidates]);
// Shadow-root styles cannot register @property defaults. Make Tailwind's
// fallback unconditional so border, shadow, and ring utilities have defaults.
const compiledCss = compiler.build([...candidates]);
const css = compiledCss.replace(
/(@layer properties \{\n) @supports [^\n]*\{\n([\s\S]*?)\n \}\n(\})/,
"$1$2\n$3",
);
if (css === compiledCss || /@layer properties\s*\{\s*@supports\b/.test(css)) {
throw new Error("Tailwind @property fallback was not unwrapped; update the pattern above.");
}
const encodedCss = `'${css
.replaceAll("\\", "\\\\")
.replaceAll("'", "\\'")
Expand Down
Loading
Loading