Skip to content

feat(web): preview pull request links on hover - #9382

Closed
flamboh wants to merge 1 commit into
pingdotgg:mainfrom
flamboh:t3code/research-github-link-previews
Closed

flamboh wants to merge 1 commit into
pingdotgg:mainfrom
flamboh:t3code/research-github-link-previews

feat(web): preview pull request links on hover

266d3c1
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Sep 4, 2026 in 1m 44s

Effect Service Conventions: no issues found

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

In-scope changed files (matching apps/**/*.ts, packages/**/*.ts, infra/**/*.ts, excluding **/*.test.ts):

  • apps/web/src/components/pullRequest/pullRequestLinkPreview.logic.ts — new pure URL/project resolution helper; no Effect service definition, layer, error class, or runtime boundary is introduced.
  • apps/web/src/lib/openPullRequestLink.ts — the only change is widening findProjectForChangeRequest to a generic over Pick<EnvironmentProject, "repositoryIdentity">; no Effect service, import-namespace, error, or runtime convention is affected.

The remaining changed files (ChatMarkdown.tsx, PullRequestGhosts.tsx, PullRequestLinkPreview.tsx, pullRequestLinkPreview.logic.test.ts) fall outside this check's scope and were used only as context.


🔍 Agent activity — 2 tool calls

💭 I'm checking which changed files fall within the .ts include patterns, since the tsx files are excluded — narrowing it down to pullRequestLinkPreview.logic.ts and openPullRequestLink.ts as the in-scope files. Neither appears to touch Effect services: the logic file is pure parsing helpers, and the other change looks like a generic type parameter tweak. I want to double check openPullRequestLink.ts directly to confirm it has no Effect usage.

1. browse_code — apps/web/src/lib/openPullRequestLink.ts

2. browse_code — apps/web/src/components/pullRequest/pullRequestLinkPreview.logic.ts

💭 The changes in openPullRequestLink.ts are just a generic signature widening, with no Effect service concerns in the modified lines. No findings here—reporting all clear.


Agent Credits: 21 credits

Token usage: 4 uncached input · 22,059 cache-read input · 24,869 cache-write input · 1,169 output
Agent Credits may also include non-token charges from external tools such as web research.