Skip to content

perf(server): make terminal history updates incremental - #9357

Closed
burnmandont wants to merge 1 commit into
pingdotgg:mainfrom
burnmandont:perf/incremental-terminal-history
Closed

burnmandont wants to merge 1 commit into
pingdotgg:mainfrom
burnmandont:perf/incremental-terminal-history

perf(server): make terminal history updates incremental

ed17b7d
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check succeeded Sep 3, 2026 in 1m 28s

No issues identified (7 code objects reviewed).

• Merge Base: 1575ada
• Head: ed17b7d

Details

✅ File Path U3 Bytes Comments Posted Reason
✅ docs/internals/terminal-runtime.md 2078 0
➖ apps/server/src/terminal/Manager.test.ts 906 Excluded by default ignore patterns
✅ apps/server/src/terminal/Manager.ts 6828 0

Billed Total: 10.00KB of diff | $0.50 (This review was charged at our per-review byte minimum of 10.00KB. Learn more here)

Filtered Issues Details

apps/server/src/terminal/Manager.ts
  • line 823: append drops a newline-only chunk when the existing history already ends in a newline. For example, appending "\n" to retained "a\n" takes the this.trailingNewline branch with an empty appendedLines array, leaving the value "a\n" rather than "a\n\n". PTY chunk boundaries can split consecutive blank lines this way, so terminal history and persisted/snapshotted output silently lose empty lines. [ Out of scope (triage) ]