feat(web): choose whether links open in the default browser or in T3 Code - #9339
UI Consistency: No issues found
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/ui-consistency.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed the changed .tsx files in apps/web/src (no .css changes in this PR). The new BrowserLinkTargetSetting in IntegrationsSettings.tsx uses the shared Select/SettingsRow primitives and matches the trigger/popup/item conventions of the neighbouring browser settings. Other changed components only rewire link-opening callbacks and thread-ref props; no new custom controls, global CSS, inline style objects, or duplicated primitive markup were introduced.
🔍 Agent activity — 4 tool calls
💭 I'm checking the changed tsx files—there's a new BrowserLinkTargetSetting using the Select primitive in IntegrationsSettings.tsx, and the ExternalLinkIcon was removed from GitActionsControl. I want to compare it against how other settings implement their selects for consistency.
1. browse_code — In apps/web/src/components/settings/IntegrationsSettings.tsx, show the other Select-based SettingsRow implementations (e.g. browser recording frame rate, browser default viewport/profile settings) including their SelectTrigger/SelectPopup/SelectItem usage and className props, so I can compare with a newly added BrowserLinkTargetSetting.
2. browse_code — apps/web/src/components/settings/IntegrationsSettings.tsx
💭 The new setting looks consistent with conventions. I should also check GitActionsControl since it removed the ExternalLinkIcon — I want to verify the button still looks visually consistent after that change.
3. browse_code — apps/web/src/components/GitActionsControl.tsx
4. browse_code — apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx
💭 The raw button in ChecksPopover already existed, just the click handler changed, so that's not a new issue. The icon removal is more of a consistency tweak than a rule violation, and there are no CSS changes or copied markup in new components, so everything looks clear.
Agent Credits: 62 credits
Token usage: 14 uncached input · 142,272 cache-read input · 68,120 cache-write input · 3,692 output
Agent Credits may also include non-token charges from external tools such as web research.