Skip to content

chore: audit lint directives and move plugin allowlists into config - #9300

Merged
juliusmarminge merged 2 commits into
mainfrom
t3code/audit-node-imports-directives
Sep 3, 2026
Merged

juliusmarminge merged 2 commits into
mainfrom
t3code/audit-node-imports-directives

test: migrate three legacy manual Effect runners to @effect/vitest

93b7ea6
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - UI Consistency succeeded Sep 3, 2026 in 1m 55s

All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/ui-consistency.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — 3 tool calls

💭 I'm focusing on two files, ThemeSearchSection.tsx and useTheme.ts, checking whether the eslint-disable comment removal for exhaustive-deps means installingId was actually added to the dependency array or if it's just a comment-level change. For useTheme.ts, I'm noting the replacement of an oxlint-disable comment with an explicit void document.documentElement.offsetHeight statement, which still forces the reflow read even though the value is discarded. I'll pull up the actual ThemeSearchSection file to confirm the dependency array situation.

1. browse_code — apps/web/src/components/settings/ThemeSearchSection.tsx

2. browse_code — apps/web/src/hooks/useTheme.ts

💭 I'm confirming that the reflow-forcing property access won't get stripped by minifiers like terser or esbuild by default, since they treat it as side-effectful. Just a small comment update in ThemeSearchSection otherwise. Now checking whether installingId was already part of the dependency array before this change, or if it's newly added — need to compare against the merge base version.

3. git_tools — apps/web/** 994bd73..93b7ea6

💭 Both changes are just comment/no-op fixes — installingId was already tracked in deps, and removing the eslint-disable is fine since runSearch itself already captures the sortBy dependency, so exhaustive-deps is satisfied. Since I don't see any UI consistency issues, I should respond with "All clear."


Agent Credits: 18 credits

Token usage: 6 uncached input · 110,444 cache-read input · 10,919 cache-write input · 1,557 output
Agent Credits may also include non-token charges from external tools such as web research.