Skip to content

refactor(media): unify file and media previews across clients - #9253

Merged
juliusmarminge merged 8 commits into
mainfrom
t3code/mobile-media-viewers
Sep 3, 2026
Merged

juliusmarminge merged 8 commits into
mainfrom
t3code/mobile-media-viewers

fix(web): sent videos play inline through the shared player

452f18a
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Sep 3, 2026 in 28s

All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — 2 tool calls

💭 This diff is mostly React/UI code for mobile/web media viewers, so Effect service conventions barely apply. I'm checking the changed .ts files—markdownLinks, mediaSource, mediaActions, mediaReference, state/assets, work-log/presentation, and a deleted workspace-file-image-cache.ts that used Data.TaggedError and Atom—and since that deletion just removes an Effect module, there's no violation there. The state/assets.ts additions use existing subpath import patterns from effect/unstable/reactivity, which matches pre-existing style rather than introducing anything new. I want to look at the full content of assets.ts to confirm there's no new Effect service or Layer definition hiding in there.

1. browse_code — packages/client-runtime/src/state/assets.ts

2. browse_code — packages/client-runtime/src/mediaSource.ts

💭 No Effect service definitions were created or refactored, and nothing violates the conventions, so there are no findings. Since the check defaults to failure but instructs stopping immediately with an exact "All clear" response when there's nothing to report, I need to decide whether to output that directly or go through complete_check first. The explicit instruction not to add title, explanation, punctuation, Markdown, or JSON conflicts with calling complete_check, which would require a summary. I'll follow the direct instruction and respond exactly "All clear".


Agent Credits: 91 credits

Token usage: 6 uncached input · 226,893 cache-read input · 115,870 cache-write input · 1,055 output
Agent Credits may also include non-token charges from external tools such as web research.