Skip to content

feat(claude): reauthenticate failed V2 threads - #9179

Draft
flamboh wants to merge 3 commits into
pingdotgg:t3code/codex-turn-mappingfrom
flamboh:t3code/claude-reauthenticate-chat
Draft

feat(claude): reauthenticate failed V2 threads#9179
flamboh wants to merge 3 commits into
pingdotgg:t3code/codex-turn-mappingfrom
flamboh:t3code/claude-reauthenticate-chat

Conversation

@flamboh

@flamboh flamboh commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Note

🤖 GPT-6 on behalf of Oliver

ELI5

Sign back into Claude from the failed thread, including when the environment runs on another machine.

Problem

Expired Claude subscription credentials strand a failed task. This draft targets Julius's V2 branch, t3code/codex-turn-mapping, and depends on #2829.

Fix

Run Claude login on the selected environment and provider instance, show its browser link, and accept a pasted code in web, desktop, and mobile. V2 captures the failed run before login and retries its persisted prompt and attachments only while it remains current. Login and retry have separate outcomes; cancellation and changed threads or provider settings cannot silently resume stale work.

UI Changes

Before

The thread shows an authentication error without an in-app recovery action.

After

The error offers Reauthenticate. The dialog reports sign-in and whether the task resumed.

Validation

Focused authentication, provider maintenance, V2 recovery, and client tests; scoped server, contracts, client-runtime, web, and mobile typechecks; targeted lint and formatting.

Live V2 sign-in and new UI video evidence are pending.

Changes by GPT-6 through Codex, with GPT-5.6 Luna agents assisting implementation and review.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 2, 2026
Comment thread apps/server/src/provider/providerMaintenanceRunner.ts Outdated
Comment thread packages/client-runtime/src/state/server.ts Outdated
Comment thread apps/server/src/provider/Layers/ClaudeAdapter.ts Outdated
Comment thread apps/server/src/provider/providerMaintenanceRunner.ts Outdated
Comment thread apps/web/src/components/ChatView.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a cross-layer Claude reauthentication workflow that launches an interactive login command, handles provider credentials and environment selection, persists new error state, and exposes a new authorized RPC. The authentication-sensitive scope and unresolved risks around command output, instance targeting, and locality require human review.

Not approved because:

  • 3 blocking correctness issues found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

@flamboh
flamboh marked this pull request as draft September 2, 2026 06:46
@flamboh
flamboh force-pushed the t3code/claude-reauthenticate-chat branch from 55bd424 to be84a95 Compare September 2, 2026 23:01
@github-actions github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Sep 2, 2026
Comment thread apps/server/src/provider/claudeAuthFlow.ts Outdated
Comment thread apps/server/src/provider/providerMaintenanceRunner.ts Outdated
Comment thread apps/server/src/provider/claudeAuthFlow.ts Outdated
Comment thread apps/server/src/provider/claudeAuthFlow.ts Outdated
Comment thread apps/mobile/src/features/threads/ClaudeReauthenticationSheet.tsx Outdated
Comment thread apps/web/src/components/chat/ClaudeReauthenticationDialog.tsx Outdated
Comment thread apps/mobile/src/features/threads/ThreadDetailScreen.tsx
Comment thread apps/web/src/components/chat/ClaudeReauthenticationDialog.tsx
Comment thread apps/web/src/components/chat/ClaudeReauthenticationDialog.tsx Outdated
@flamboh
flamboh force-pushed the t3code/claude-reauthenticate-chat branch from be84a95 to 9bc1d43 Compare September 3, 2026 00:23
@flamboh

flamboh commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Note

🤖 GPT-5.6 Sol on behalf of Oliver

Remote Claude reauthentication:

claude-remote-reauthentication.webm

@flamboh
flamboh marked this pull request as ready for review September 3, 2026 00:51
@flamboh
flamboh marked this pull request as draft September 3, 2026 02:54
@flamboh flamboh changed the title feat(claude): reauthenticate from the chat error banner feat(claude): reauthenticate failed V2 threads Sep 6, 2026
@flamboh
flamboh changed the base branch from main to t3code/codex-turn-mapping September 6, 2026 08:50
@flamboh
flamboh force-pushed the t3code/claude-reauthenticate-chat branch from 9548242 to 35589eb Compare September 6, 2026 08:52
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Sep 6, 2026
Comment thread apps/web/src/components/chat/ClaudeReauthenticationDialog.tsx
Comment thread apps/web/src/components/chat/ClaudeReauthenticationDialog.tsx
Comment thread packages/client-runtime/src/state/server.ts
Comment thread apps/server/src/provider/providerMaintenanceRunner.ts Outdated
Comment thread apps/server/src/orchestration-v2/Orchestrator.ts
Comment thread apps/server/src/orchestration-v2/Orchestrator.ts Outdated
Comment thread packages/client-runtime/src/claudeReauthentication.ts Outdated
Comment thread apps/server/src/provider/claudeAuthFlow.ts Outdated
Comment thread apps/server/src/provider/claudeAuthFlow.ts Outdated
Comment thread apps/server/src/provider/claudeAuthFlow.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant