feat(web): copy the full error report from the error page - #9166
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 77a5bb4. Configure here.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This production-facing PR adds a new error-report copying capability and changes the root error page from collapsible details to an always-visible report, including nested causes and runtime metadata. The implementation is localized and does not touch backend, schema, auth, billing, or deployment code, but the new user-facing behavior lacks focused test coverage and merits human review. You can add or adjust custom eligibility rules. Learn more. |
Merges 137 upstream commits (`d937e3075..36c4e9c`) into the fork, following the `fork-upstream-merge` skill. Landed as a merge commit; conflicts resolved by the inventory's cached verdicts. ## Merge shape 816 files landed (`git diff --stat HEAD^1 HEAD`) against 811 in the upstream range; fork delta 650 files. The gap of five is all in landed and not the range: two fork-owned files touched during resolution (`sandboxControl.placement.test.tsx` test-prop fixup, `useSandboxCommandsBanner.tsx` reformat) plus the three fork docs this merge writes (`inventory.json`, `gaps.md`, `upstream-merge-log.md`). No upstream work was dropped. ## Conflicts Resolved by inventory verdict — `AGENTS.md` (kept the fork's slimmed shape, added Antigravity to the provider list), `contracts/rpc.ts` and `environment.ts`, the ChatView/MessagesTimeline thread-fork + message-origin convergence, the preview cluster (`addBrowserSurface` `profileId` beside the fork's `url`, `rightPanelStore` `openAttachment` beside `retargetFile`), the settings gates, and the two upstream pingdotgg#9364 test deletions. Two latent fork bugs surfaced and were fixed: `PreviewView`'s hosted annotation handler called an unexported helper, now routed through the exported `capturePreviewAnnotationScreenshot` wrapper (matching the sibling native handler); and `ChatView` passed a `configuredUrls` prop the fork's hosted `PreviewPanel` does not accept. ## Unsupported methods `unsupported-methods.mjs` reported ADD 10; recomputed to 0 by adding `UnsupportedMethodError` to the shared `ProviderSetupRpcError` union (nine `provider.auth.*` / `provider.install.*` methods) and to `server.refreshUsageRates`. `gaps.md` grown with a _Provider setup_ bullet and a `refreshUsageRates` clause on _Usage summary_. The three DROP entries (`scripts.run`, `subtasks.list`, `threads.getShell`) are the documented keep-anyway exceptions — `apps/server` still refuses them. ## Feature classification **Usable as-is** (UI only, no backend dependency): mod+w tab close (pingdotgg#9363), PageUp/PageDown chat nav (pingdotgg#9315), diff/PR file tree (pingdotgg#9330), diff-header copy path (pingdotgg#2403), error-report copy (pingdotgg#9166), opt-in context-window indicator (pingdotgg#9190), opt-in panel animations (pingdotgg#8830), proactive panels (pingdotgg#9276), button press feedback (pingdotgg#9349), provider-editor redesign chrome (pingdotgg#8508). **Unsupported in Moatless** (resolve to a refusal): Antigravity provider auth/install and all `provider.*` setup (pingdotgg#9348, pingdotgg#8508), `server.refreshUsageRates`. Desktop-only and already capability- or desktop-gated, so no new fork work: preview browser profiles (pingdotgg#7254), open-links-in-app (pingdotgg#9339), ssh-host suggestions (pingdotgg#9171), environment-as-machine (pingdotgg#9299), continue-threads-across-restart (pingdotgg#9167, rides the new `serverUpdateThreadContinuation` capability). **Backend behavior to reproduce** if Moatless wants it: project icons (pingdotgg#9137, migration 047), auto-pull clean default branches (pingdotgg#9277, migration 045), inline citations (pingdotgg#9146, needs the backend to emit them), the usage page. Migration 046 (RepairAutomaticSettlementTimestamps) is upstream-server-only. Net-zero: context compaction (pingdotgg#8808) landed and was reverted (pingdotgg#9284). ## Verification `fmt:check`, `lint`, `typecheck`, `tripwires` and `inventory-check` green. Full test suite green — one web test failed initially (`addBrowserSurface.test.ts` did not expect the converged default `profileId`), fixed and re-run. Two `verify.mjs` checks exit non-zero and are the caveated machine failures: `unsupported-methods` on the three documented DROP exceptions above, and `duplicate-adds` on three confirmed false positives (`openPreview` in a `ChatView` object literal vs its deps array; three distinct `it()` blocks in `addBrowserSurface.test.ts`). Written by Claude Opus 5 in Claude Code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- Moatless task: https://moatless.soaplabstest.com/tasks/4e881239-73d1-4a93-9563-6a926e920b42

When the app hits the root error page, the stack trace is hidden behind a collapsed "Show error details" toggle and there is no way to copy it. Users reporting a crash have to select text out of a scrolling pre by hand, and lose the app version and page they were on.
The error page now shows an always-open error report and a Copy error button next to Try again and Reload app. The report contains the app name and version, the page path, an ISO timestamp, the stack, and up to five levels of the cause chain. The path excludes the query string so pairing tokens never reach the clipboard. Copying uses the existing clipboard hook and flips the button to a check mark for two seconds.
Before
After
Made with Claude Fable 5.1 in T3 Code.
🤖 Generated with Claude Code
Note
Low Risk
UI-only changes on the error boundary and clipboard copy of client-side error text; no auth, persistence, or core routing logic changes.
Overview
The root router error page now surfaces a always-visible error report instead of a collapsed “Show error details” section, so users can see context without expanding a
<details>block.A Copy error action (via
useCopyToClipboard) copies a formatted report that includes app name/version, router pathname (not the query string, to avoid leaking tokens), ISO timestamp, stack/details, and up to fiveError.causelevels. Pathname comes from TanStack Router so desktop hash history still records the real route. The copy button shows brief “Copied” / check feedback.The report panel uses wrapping and a slightly taller scroll area than the old hidden pre block.
Reviewed by Cursor Bugbot for commit 9ff7bf8. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add copy-to-clipboard button for full error report on error page
Replaces the expandable error-details disclosure in
RootRouteErrorViewwith an always-visible error report panel and a newCopyErrorButtonthat copies the report and shows a copied confirmation state.errorReportformatter assembles app name and version, router pathname, ISO timestamp, error details, and up to five nestedErrorcause entries into a newline-separated string.window.location, so query-string content is excluded from the report.📊 Macroscope summarized 9ff7bf8. 1 file reviewed, 2 issues evaluated, 0 issues filtered, 1 comment posted
🗂️ Filtered Issues